Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Optimize error messages #1159

Merged
merged 7 commits into from
Mar 25, 2023
Merged

feat: Optimize error messages #1159

merged 7 commits into from
Mar 25, 2023

Conversation

Yushu2606
Copy link

@Yushu2606 Yushu2606 commented Mar 25, 2023 •
edited
Loading

Description

LiteLoader

Before (Always in English)
image

After (Use current culture)
image

Preloader

Before (Displays a message box on the desktop)
image

After (The message box disappeared)
image

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing Note
  • I am responsible for any copyright issues with my code if it occurs in the future.

@Yushu2606 Yushu2606 changed the title feat: 优化错误提示 feat: Optimize error messages Mar 25, 2023
@Yushu2606
Copy link
Author

LiteLDev/PreLoader#1

Jasonzyt
Jasonzyt previously approved these changes Mar 25, 2023
View reviewed changes
@Yushu2606 Yushu2606 requested a review from Jasonzyt March 25, 2023 12:22
@yqs112358
Copy link
Member

好东西好东西

@ShrBox ShrBox merged commit 141d5c6 into LiteLDev:develop Mar 25, 2023
@Yushu2606 Yushu2606 deleted the patch-1 branch March 25, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OEOTYAN OEOTYAN OEOTYAN approved these changes

@ShrBox ShrBox ShrBox approved these changes

@yqs112358 yqs112358 yqs112358 approved these changes

@Jasonzyt Jasonzyt Awaiting requested review from Jasonzyt

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yushu2606 @yqs112358 @ShrBox @OEOTYAN @Jasonzyt