Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc.explode()若参数isDestroy=true,无论isFire=true/false都会产生火焰 #959

Closed
mrmagic2020 opened this issue Dec 19, 2022 · 2 comments · Fixed by #1106
Closed

mc.explode()若参数isDestroy=true,无论isFire=true/false都会产生火焰 #959

mrmagic2020 opened this issue Dec 19, 2022 · 2 comments · Fixed by #1106
Labels
bug Related to software malfunction priority: medium Needs attention
Milestone

Comments

@mrmagic2020
Copy link

异常模块

ScriptEngine (脚本引擎)

操作系统

Windows Server 2019

LiteLoader 版本

2.9.0

BDS 版本

1.19.50

发生了什么?

使用函数mc.explode(pos,source,power,range,isDestroy,isFire)制造爆炸时,只要isDestroy=true,则产生的爆炸都会有火焰,忽视isFire的值。

复现此问题的步骤

  1. mc.explode(pos,source,power,range,true,false);
  2. 爆炸留下燃烧的火焰

有关的日志/输出

No response

插件列表

No response

@mrmagic2020 mrmagic2020 changed the title mc.explode()若参数isDestroy=true,无论isFire的值都会产生火焰 mc.explode()若参数isDestroy=true,无论isFire=true/false都会产生火焰 Dec 19, 2022
@Jasonzyt Jasonzyt added the status: review needed Requires assessment or evaluation label Dec 21, 2022
@Redbeanw44602 Redbeanw44602 added bug Related to software malfunction module: LiteLoader priority: medium Needs attention and removed status: review needed Requires assessment or evaluation labels Jan 15, 2023
@Redbeanw44602
Copy link
Contributor

Redbeanw44602 commented Jan 15, 2023

最后一个参数 isFire 似乎失效了,目前是

isBreaking = true,isFire = false ---> 破坏方块 + 创建火
isBreaking = false,isFire = true ---> 不破坏方块 + 不创建火

@futrime futrime added this to the 3.0.0 milestone Feb 10, 2023
KobeBryant114514 added a commit to KobeBryant114514/LeviLamina that referenced this issue Feb 28, 2023
@KobeBryant114514
Copy link
Contributor

@Redbeanw44602 并不是LiteLoader本体的问题,而是 Level::createExplosion 这个API变了,而脚本引擎没有做出对应的调整。
实际上最后一个参数isFire实际上传入的是 maxResistance,而参数range 传入的才是 isFire。
range这个参数并不存在。

KobeBryant114514 added a commit to KobeBryant114514/LeviLamina that referenced this issue Mar 1, 2023
KobeBryant114514 added a commit to KobeBryant114514/LeviLamina that referenced this issue Mar 1, 2023
@Jasonzyt Jasonzyt modified the milestones: 3.0.0, 2.12.0 Mar 2, 2023
@Jasonzyt Jasonzyt linked a pull request Mar 2, 2023 that will close this issue
KobeBryant114514 added a commit to KobeBryant114514/LeviLamina that referenced this issue Mar 2, 2023
OEOTYAN added a commit to KobeBryant114514/LeviLamina that referenced this issue Mar 2, 2023
@ShrBox ShrBox closed this as completed in 380123e Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Related to software malfunction priority: medium Needs attention
Development

Successfully merging a pull request may close this issue.

5 participants