Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use another name for decorator in BaseLib.py #1200

Closed
callstackexceed opened this issue Apr 17, 2023 · 2 comments
Closed

Use another name for decorator in BaseLib.py #1200

callstackexceed opened this issue Apr 17, 2023 · 2 comments
Assignees
@yqs112358
Labels
status: review needed Requires assessment or evaluation

Comments

@callstackexceed
Copy link

Is your feature request related to a problem? Please describe.

Currently, a decorator is named @listener in BaseLib.py, which is strange,
because decorator in Python is commonly named as a verb.

Describe the solution you'd like

I suggest use @handle instead of @listener.
Since the name is just in develop branch and haven't been released,
I think it is possible to change name now.
@OEOTYAN OEOTYAN added module: script engine status: review needed Requires assessment or evaluation labels Apr 19, 2023
@yqs112358
Copy link
Member

我个人感觉这个不算什么大问题。
麻烦 @lgc2333 大佬看看捏

@lgc2333
Copy link

lgc2333 commented Apr 19, 2023

approve

@lgc2333 lgc2333 mentioned this issue Apr 19, 2023
Merged
yqs112358 added a commit that referenced this issue Apr 19, 2023
@yqs112358
chore: #1200 (#1203)
cd62fc8
ShrBox pushed a commit that referenced this issue Apr 20, 2023
@lgc2333 @ShrBox
refactor: #1200 (#1203)
46622be
@ShrBox ShrBox closed this as completed Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yqs112358 yqs112358

Labels
status: review needed Requires assessment or evaluation
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yqs112358 @ShrBox @OEOTYAN @lgc2333 @callstackexceed