Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4389 This commit will fix the label display #3387

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from

Conversation

den4ik1203
Copy link
Collaborator

Description

This commit will fix the label display.

Jira link:
https://lite-farm.atlassian.net/browse/LF-4389
Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@den4ik1203 den4ik1203 requested review from a team as code owners August 19, 2024 13:10
@den4ik1203 den4ik1203 requested review from Duncan-Brain and SayakaOno and removed request for a team August 19, 2024 13:10
Comment on lines +16 to 22
.labelContainer {
display: flex;
justify-content: space-between;
justify-content: flex-start; /* Keep items together */
min-height: 20px;
position: relative;
white-space: nowrap; /* Prevent wrapping */
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original CSS for this class looks fine to me.
I wonder why tooltipIconContainer has a width of 100%, which is causing the issue. Removing all the styles from tooltipIconContainer fixes the issue, but could this break anything else?

I would ask Navdeep for his inputs so that we can fix it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants