Lf 3334 investigate node 16 eol sept 2023 #2739
Conversation
…rial ui, apply codemods, manual updates needed
…on format validator and repair Json schema
…ypes fixed and baseModel parseJson method
…neous component prop leftover from react-floater
…ormat on due_date validation
…enum and type fixing
…ue not jsonSchema and other type corrections
|
This branch should be updated with the latest |
…ving jest test failures use of base properties outside base model, deprecated quantity_kg, fakeemail on accept invite, softdelete mergeContext return dates
This commit looked to address the jest errors happening as a result of the stricter types. Includes: - seeding field work task types during test - working around the server.js function that converts dates to datetimes.
…us merge. React icons seems to have stopped supporting the export of /all -- a minor breaking change. Main repo package lock missed the previous commit so may have issues without it if checking out prev commit.
Package locks updated using the newest LTS that came out during this PR
There was a problem hiding this comment.
Great job! ... I haven't tested locally but I can imagine all the work going through all those little details.
One thing I noticed is that we didn't updated prod.Dockerfile
Forgot to remove debug statements and update dockerfiles Did NOT touch storybook.Dockerfile
|
@iperdomo Thanks totally forgot those two items. I did not touch storybook.Dockerfile .. which seems to need updating as well. |
|
@Duncan-Brain I was trying to produce a Docker image from The interesting bit |
…ge and fix type error and node version After merging integration a new lockfile was needed becasue of the vulnerable packages. However The vite override stopped the lazy loaded modules from being able to resolve. Fixed a type error on Typography component -- unsure why this just presented itself. Updated node in beta-export deploy script.
|
@iperdomo I am not sure why that only just now presented itself to be honest. I fixed it though by resolving the type error in the Typography Tooltip component. That made me wonder if other utilities from our scripts might have issues and it seems like Storybook tests are no longer passing (not sure if it was this or pre-existing but hoping to determine tomorrow). I also found that I forgot to update package-lock after merging integration (necessary because of the npm vulnerable packages). @SayakaOno there was a change to the overrides made in /webapp -- the vite override was causing my modules not to allow lazy loading. I deleted the overrides and re-ran pnpm audit fix and that specific override did not rejoin. @kathyavini I added the node update to the deploy script thanks! |
There was a problem hiding this comment.
I've been using this branch exclusively for several days and it's great -- super stable!! I see one deprecation warning on the frontend which I think can be its own ticket?
There's a good chance we'll have to do a one-time nvm install on the beta export server droplet before we can nvm use 18.16.1 (so no worries if it fails the first time). I just added updating the prod version of our export server to our release checklist -- hopefully our version of pm2 is compatible with Node 18.16.1 🤞 -- Is there anything else related to this update that should go on the release checklist?
And you really held firm on not updating the Docker Hub Image reference 😉 I'll open a PR once this one is merged, then.
Wonderful job on another massive undertaking 🙂
| @@ -1,6 +1,13 @@ | |||
| import { createTheme, ThemeProvider } from '@material-ui/core'; | |||
| import { createTheme, StyledEngineProvider } from '@mui/material'; | |||
| import { adaptV4Theme, ThemeProvider, Theme } from '@mui/material/styles'; | |||
There was a problem hiding this comment.
I see a deprecation warning with adaptV4Theme in my console, but I'm assuming that's an issue for another time, since the theme itself will need to be refactored?
There was a problem hiding this comment.
definitely another time! If it ain't broke..
There was a problem hiding this comment.
Alright I'll make a ticket
This updates the package locks again. Current state of storybook is 33 tests failing. All else working
|
I confirmed that tests for the unit component ran successfully for me, too. I'm not able to run tests in integration branch, so I can't compare the result, but I know all tests were not passing before, and I guess it should be good! |
Description
Upgrading Node 16 to Node 18.16.1 LTS and dealing with the issues that follow from that.
Overview of what was done:
All
Frontend
import {VSCDialog} from react-icons/all-->import {VSCDialog} from react-icons/vscBackend
Other:
Why not use $BeforeValidate: Vincit/objection.js#77
Why I did not use objection-js-soft-delete (fix does not work in jest): alex-w0/objection-js-soft-delete#116
What made me try objection-js-soft-delete several times: griffinpp/objection-soft-delete#18
Testing out of use routes like Pesticide with Postman requires Body data in delete request (bad pattern) to test anyway comment out rejectInBodyGetAndDelete in server.js .
Jira link: LF-3334
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: