Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] General issues and improvements #488

Merged
merged 37 commits into from
Feb 14, 2022
Merged

[FIX] General issues and improvements #488

merged 37 commits into from
Feb 14, 2022

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Feb 14, 2022

🐛 Fix Large Lissy93 /FIX/general-issues → Lissy93/dashy Commits: 37 | Files Changed: 42 | Additions: 626

Addresses most of the currently open issues.

Category: Bugfix

Overview

Issue Number #452, #454, #455, #463, #479, #482, #483, #485, #486, #487

New Vars
How read/ write permissions have been updated.
You can prevent any user from writing changes to disk, using preventWriteToDisk. Or prevent any changes from being saved locally in browser storage, using preventLocalSave. To disable all UI config features, including View Config, set disableConfiguration. All properties added under appConfig

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

RIP my hand written YAML parser, you served me well. Replaced with the js-yaml node package
This should make it easier for users to understand exactly where an issue is, and give clear instructions on how to fix it
@netlify
Copy link

netlify bot commented Feb 14, 2022

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 075bca9

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/620a5bda9717f3000a8919d9

😎 Browse the preview: https://deploy-preview-488--dashy-dev.netlify.app/

@liss-bot liss-bot added the 🦋 Bug Fix [PR] Code includes bug fixes label Feb 14, 2022
@viezly
Copy link

viezly bot commented Feb 14, 2022

This pull request is split into 8 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • .github
  • /
  • docs
  • services
  • src
  • src/components
  • src/styles
  • src/utils
  • src/views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦋 Bug Fix [PR] Code includes bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants