Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validate flags #284

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix validate flags #284

merged 1 commit into from
Sep 26, 2024

Conversation

catbash
Copy link
Contributor

@catbash catbash commented Sep 24, 2024

Type

Amendment


Changes

I noticed that make validate was failing with the following error on 3 lines:

WARNING:__main__:Validation error: Additional properties are not allowed ('reddit' was unexpected)

I updated the lines using the additional reddit property to use the subreddit property as described in the schema so that the validation will pass again without warnings.


Supporting Material

https://github.com/Lissy93/awesome-privacy/blob/main/lib/schema.json#L35
Line 35 of the repo's schema file declares a subreddit property. There is no reddit property available.


Affiliation

N/A


Checklist

  • I have read the Contributing guide, and confirmed my PR aligns with the requirements
  • I have performed a self-review (valid Markdown formatting, spelling, and grammar)
  • I have indicated whether I have any affiliation with any software / services added
  • I agree to follow the repositories Contributor Covenant Code of Conduct

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@Lissy93 Lissy93 merged commit 874dbda into Lissy93:main Sep 26, 2024
1 check failed
@catbash catbash deleted the fix-validate branch September 30, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants