This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
Transaction filters upgrade - Closes #880 #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 18, 2019 16:39
added 9 commits
April 2, 2019 14:32
added 11 commits
April 25, 2019 10:59
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Due to technical difficulties, the filters and sorting did not work on the account page.
How did I fix it?
The pagination logic and filters are rewritten.
It improves the sorting feature by requesting data from the server directly and not sorting the limited amount of data available in the view.
How to test it?
Run the app and check the account page. Transactions should be sorted properly.
Review checklist
commit guidelines