Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Show total number of votes - Closes #874 #877

Merged
merged 3 commits into from
Jan 9, 2019
Merged

Conversation

youxiberlin
Copy link
Contributor

@youxiberlin youxiberlin commented Jan 8, 2019

What was the problem?

  • A delegate profile showed the paginated amount of vote, not the total number of the voters.

How did I fix it?

  • Changed {{vm.address.votes.length} to {{vm.address.votersMeta.count}}

How to test it?

  • Checked on browser.

Review checklist

@MichalTuleja MichalTuleja changed the title Show total number of votes - Closes #876 Show total number of votes - Closes #874 Jan 8, 2019
Copy link
Contributor

@MichalTuleja MichalTuleja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks correct now.
Could you please also update the delegate.feature file, so it tests the actual delegate /account page with voter and vote count?

@MichalTuleja MichalTuleja merged commit a6a5609 into 2.2.1 Jan 9, 2019
@MichalTuleja MichalTuleja deleted the 874-total-num-vote branch January 9, 2019 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants