Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Fix grid of top section of Delegate Monitor - Closes #859 #869

Merged
merged 3 commits into from
Dec 20, 2018
Merged

Fix grid of top section of Delegate Monitor - Closes #859 #869

merged 3 commits into from
Dec 20, 2018

Conversation

youxiberlin
Copy link
Contributor

What was the problem?

  • The height of the child elements in the top section at Delegate Monitor were not consistent, and it sometimes caused wrong collapse of some elements.

How did I fix it?

  • Applied flex and flex-wrap in the parent container, and made the height of all the child elements same.
  • Refactored the template code accordingly.

How to test it?

  • Checked on the browser.

Review checklist

  • The PR solves General UI update #859
  • All new code is covered with unit tests
  • All new code was formatted with Prettier
  • Linting passes
  • Tests pass
  • Commit messages follow the
    commit guidelines
  • Documentation has been added/updated

@MichalTuleja MichalTuleja changed the title Fix grid of top section of Delegate Monitor - #859 Fix grid of top section of Delegate Monitor - Closes #859 Dec 20, 2018
@MichalTuleja MichalTuleja merged commit 63aaca8 into 2.2.0 Dec 20, 2018
@MichalTuleja MichalTuleja deleted the 859-delegate-monitor-top-layout branch December 20, 2018 14:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalTuleja MichalTuleja MichalTuleja approved these changes

Assignees

@MichalTuleja MichalTuleja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youxiberlin @MichalTuleja