This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
Configure cookie expiry date - Closes #841 #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalTuleja
suggested changes
Dec 7, 2018
| $scope.clicked = () => { | ||
| $scope.visible = false; | ||
| $cookies.put(cookieKey, 'true'); | ||
| $cookies.put(cookieKey, 'true', { 'expires': expireDate }); |
There was a problem hiding this comment.
Jenkins test fails on ESlint step. Once this line aligns to the ESlint rules, the tests should pass.
| @@ -20,9 +20,13 @@ const directiveCtrl = ($scope, $cookies) => { | |||
| $scope.visible = true; | |||
| const cookieKey = 'cookiesBannerConfirmed'; | |||
|
|
|||
| // setting expireDate to 2 years ahead | |||
| const expireDate = new Date(); | |||
| expireDate.setDate(expireDate.getDate() + 730); | |||
There was a problem hiding this comment.
The 730 value should be written as const with a proper name.
MichalTuleja
approved these changes
Dec 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Cookie expire date for the cookie banner was not working.
How did I fix it?
How to test it?
Review checklist
commit guidelines