Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Use Node.js 8.14.0 - Closes #837 #838

Closed
wants to merge 3 commits into from
Closed

Conversation

fchavant
Copy link
Contributor

What was the problem?

Node.js 8.11.2 was being used while there have been several security updates for the 8.x branches.

How did I fix it?

Bump version to 8.14.0 in .nvmrc and made the Jenkinsfile use the version from that file.

How to test it?

Run Jenkins build; ensure version 8.14.0 is being used.

Review checklist

@fchavant fchavant force-pushed the 837-use-node.js-8.14.0 branch 4 times, most recently from 79dd909 to 1be601c Compare November 30, 2018 11:40
@fchavant fchavant force-pushed the 837-use-node.js-8.14.0 branch 2 times, most recently from 5a1218b to 555c303 Compare November 30, 2018 11:57
@fchavant fchavant self-assigned this Nov 30, 2018
@fchavant
Copy link
Contributor Author

12 tests are broken by the new (>=1.1) test snapshot; see https://jenkins.lisk.io/job/lisk-explorer/job/PR-838/12/#showFailuresLink

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants