This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
Fix market watcher candles endpoints - Closes #368 #378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
The candlestick charts for the Bittrex exchange were not shown correctly. The backend part of the application that is responsible for this was missing the crucial data, that were not able to be gathered from the original data source - Bittrex API version 1.1.
How did I fix it?
I switched to the version 2.0 of the Bittrex exchange API.
The new data provided by the API are candlestick data itself, with an interval of 5 mins.
Other charts, such as hour and day charts are generated from the same data source.
I've copied a lot of the original code from the
abstract.js
file. Most of the code was reused, excluding the grouping part - these functions are performing different operations, based on the data provided in the version 2.0 of Bittrex API.There is also significant overuse of the Underscore library - I've mentioned it in the issue #375.
How to test it?
Use Market Watcher to determine whether the candlesticks are rendered correctly.
Review checklist