Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Fix market watcher candles endpoints - Closes #368 #378

Closed

Conversation

MichalTuleja
Copy link
Contributor

What was the problem?

The candlestick charts for the Bittrex exchange were not shown correctly. The backend part of the application that is responsible for this was missing the crucial data, that were not able to be gathered from the original data source - Bittrex API version 1.1.

How did I fix it?

I switched to the version 2.0 of the Bittrex exchange API.
The new data provided by the API are candlestick data itself, with an interval of 5 mins.
Other charts, such as hour and day charts are generated from the same data source.

I've copied a lot of the original code from the abstract.js file. Most of the code was reused, excluding the grouping part - these functions are performing different operations, based on the data provided in the version 2.0 of Bittrex API.

There is also significant overuse of the Underscore library - I've mentioned it in the issue #375.

How to test it?

Use Market Watcher to determine whether the candlesticks are rendered correctly.

Review checklist

@karmacoma karmacoma changed the title Fix market watcher candles endpoints - closes #368 Fix market watcher candles endpoints - Closes #368 Jan 10, 2018
@reyraa reyraa requested review from karmacoma and removed request for reyraa January 16, 2018 14:59
@karmacoma karmacoma removed their request for review January 17, 2018 11:14
@karmacoma
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants