Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Write e2e tests - Closes #196 #205

Merged
merged 65 commits into from
Jul 25, 2017
Merged

Write e2e tests - Closes #196 #205

merged 65 commits into from
Jul 25, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Jun 23, 2017

Covers checked points in #196

Does not cover:

  • activity graph
  • market watcher charts
  • network monitor
  • tests on mobile screen

Those will be addressed in #204

slaweet and others added 30 commits June 19, 2017 15:16
though it's disabled as the feature doesn't work
to make e2e test time zone independent
because the list can be in different order as multiple txs have the same
timestamp
to match also address and e2e tests don't fail randomly
@Isabello
Copy link
Contributor

/api/search?id=6524861224470851795
/home/lisk/jenkins/workspace/Explorer-Pipeline_PR-205-22KSGGZHK6DQNFWMSX4336N535JVLIBMOP4P7YVPMBGT2CXNIYHQ/lib/api/delegates.js:378
return error({ success : false, error : (body.error ? body.error : err) });

TypeError: Cannot read property 'error' of undefined
at Request._callback (/home/lisk/jenkins/workspace/Explorer-Pipeline_PR-205-22KSGGZHK6DQNFWMSX4336N535JVLIBMOP4P7YVPMBGT2CXNIYHQ/lib/api/delegates.js:378:62)
at self.callback (/home/lisk/jenkins/workspace/Explorer-Pipeline_PR-205-22KSGGZHK6DQNFWMSX4336N535JVLIBMOP4P7YVPMBGT2CXNIYHQ/node_modules/request/request.js:188:22)
at emitOne (events.js:96:13)
at Request.emit (events.js:188:7)
at Request.onRequestError (/home/lisk/jenkins/workspace/Explorer-Pipeline_PR-205-22KSGGZHK6DQNFWMSX4336N535JVLIBMOP4P7YVPMBGT2CXNIYHQ/node_modules/request/request.js:884:8)
at emitOne (events.js:96:13)
at ClientRequest.emit (events.js:188:7)
at Socket.socketErrorListener (_http_client.js:309:9)
at emitOne (events.js:96:13)
at Socket.emit (events.js:188:7)

This is your failure causing tests to fail.

@Isabello Isabello changed the base branch from development to 1.3.0 July 19, 2017 14:42
@slaweet
Copy link
Contributor Author

slaweet commented Jul 19, 2017

I suppose the tests are failing because I changed test config config.lisk.port = 7000 to config.lisk.port = 4000 and I didn't manage to convince Jenkins to run Lisk core on port 7000, though I tried to: 53fac6e

Any advice on how to set it up @Isabello ?

@reyraa
Copy link
Contributor

reyraa commented Jul 25, 2017

nice work Vit. thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants