refactor(standard): add non-instanced is_a/instanceOf method#4722
Merged
refactor(standard): add non-instanced is_a/instanceOf method#4722
Conversation
hjpalpha
approved these changes
Sep 12, 2024
hjpalpha
approved these changes
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced
object:is_a(aClass)withClass.instanceOf(object, aClass). Old call pattern can still be used, but considered deprecated and will be removed in the future.Also updated some annos in streamlinks now that LuaLS/lua-language-server#2708 is fixed.
The
object:is_a(aClass)is very annoying to use, as one needs to first check ifobjectis a table andis_ais a function in that table, before being able to call it.How did you test this change?
Tested with class+infobox+widget changes