Skip to content

feat(matchTicker): add matchPage link if applicable #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rathoz merged 7 commits into from
Jul 25, 2024
Merged

feat(matchTicker): add matchPage link if applicable #4371

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
08523d4
feat(matchTicker): add matchPage link if applicable
hjpalpha Jun 26, 2024
415bedc
use icon besides tournament instead of making versus a link
hjpalpha Jul 6, 2024
25f1f1f
kick unused require
hjpalpha Jul 6, 2024
1f2b7b3
as per martins suggestion
hjpalpha Jul 8, 2024
e41c578
use the suggested icon
hjpalpha Jul 11, 2024
8bbd97e
kick unused var
hjpalpha Jul 11, 2024
5fcfae1
as per review
hjpalpha Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion components/match_ticker/commons/match_ticker_display_components.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ local String = require('Module:StringUtils')
local LeagueIcon = require('Module:LeagueIcon')
local Logic = require('Module:Logic')
local Lua = require('Module:Lua')
local Page = require('Module:Page')
local Table = require('Module:Table')
local Timezone = require('Module:Timezone')
local VodLink = require('Module:VodLink')
Expand Down Expand Up @@ -92,8 +93,11 @@ function Versus:create()
lowerText = VS
end

upperText = self:_applyMatchPage(upperText or VS)
lowerText = self:_applyMatchPage(lowerText)
Comment thread
hjpalpha marked this conversation as resolved.
Outdated

if not lowerText then
return self.root:wikitext(VS)
return self.root:wikitext(self:_applyMatchPage(VS))
end

return self.root
Expand Down Expand Up @@ -151,6 +155,15 @@ function Versus:scores()
return table.concat(scores, ':')
end

---@param str string?
---@return string?
function Versus:_applyMatchPage(str)
local matchPage = (self.match.match2bracketdata or {}).matchpage
if Logic.isEmpty(matchPage) or Logic.isEmpty(str) then return str end

return Page.makeInternalLink({}, str, matchPage)
end

---Display class for matches shown within a match ticker
---@class MatchTickerScoreBoard
---@operator call(table): MatchTickerScoreBoard
Expand Down