Remove apostrophes in comments to workaround ros2/launch_ros#214 #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As seen in ros2/launch_ros#214 and ros2/launch_ros/issues/136 launch files may have trouble getting the output of a
xacro
command if the parsed xacro files contain special YAML characters (typically apostrophes / colons inside comments).The launch file examples of Plankton use the
OpaqueFunction
approach that explicitly runsxacro
to generate a temporary URDF file. On the other hand, if theCommand
substitution is used (which is a common practice) then it fails on the current xacro files from Plankton.This PR simply removes the apostrophes in the comments, following the same workaround as other people did.