Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests to pass again #126

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Fix tests to pass again #126

wants to merge 22 commits into from

Conversation

WengerK
Copy link
Collaborator

@WengerK WengerK commented Jun 12, 2019

  • PHP 5.3 is not more supported by Drupal TI
  • PHP 5.4 & PHP 5.5 are not supported anymore by Drupal TI for Drupal 8.

PHP 5.3 is not more supported by Drupal TI as it's not supported anymore by Drupal 8.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ddcd306 on rm-travis-php53 into 5316cdd on master.

@coveralls
Copy link

coveralls commented Jun 12, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d8e2ca4 on rm-travis-php53 into 5316cdd on master.

@WengerK WengerK changed the title remove php 5.3 from testing batch remove old php from testing batch Jun 12, 2019
@WengerK WengerK changed the title remove old php from testing batch remove old php from testing Jun 12, 2019
upgrade to use PHP 7.1 & PHP 7.2
remove usage of PHP 5.5 & 5.6 for Drupal 8 - End of support by Core Team https://www.drupal.org/node/2938726
Package operations: 6 installs, 11 updates, 0 removals
  - Installing psr/container (1.0.0): Loading from cache
  - Installing container-interop/container-interop (1.2.0): Loading from cache
  - Removing symfony/class-loader (v2.6.0)
  - Installing symfony/class-loader (v3.4.28): Loading from cache
  - Installing symfony/polyfill-ctype (v1.11.0): Loading from cache
  - Removing symfony/yaml (v2.6.0)
  - Installing symfony/yaml (v3.3.18): Downloading (100%)
  - Installing symfony/polyfill-mbstring (v1.11.0): Loading from cache
  - Removing symfony/translation (v2.6.0)
  - Installing symfony/translation (v3.3.18): Downloading (100%)
  - Removing symfony/event-dispatcher (v2.6.0)
  - Installing symfony/event-dispatcher (v3.2.14): Downloading (100%)
  - Removing symfony/dependency-injection (v2.6.0)
  - Installing symfony/dependency-injection (v3.2.14): Downloading (100%)
  - Removing symfony/filesystem (v2.6.0)
  - Installing symfony/filesystem (v3.0.9): Downloading (100%)
  - Removing symfony/config (v2.6.0)
  - Installing symfony/config (v2.8.50): Downloading (100%)
  - Installing psr/log (1.1.0): Loading from cache
  - Installing symfony/debug (v3.0.9): Downloading (100%)
  - Removing symfony/console (v2.6.0)
  - Installing symfony/console (v2.8.50): Downloading (100%)
  - Updating behat/transliterator (v1.0.1 => v1.2.0): Loading from cache
  - Updating behat/gherkin (v4.3.0 => v4.6.0): Loading from cache
  - Updating behat/behat (v3.0.15 => v3.5.0): Loading from cache
Package operations: 0 installs, 1 update, 0 removals
  - Updating drupal/drupal-extension (v3.0.3 => v3.3.1): Downloading (100%)
@WengerK WengerK changed the title remove old php from testing Fix tests to pass again Jun 18, 2019
@taz77
Copy link
Contributor

taz77 commented Jun 18, 2019

The PHP 5.4 failure is in Selenium.

@taz77
Copy link
Contributor

taz77 commented Jun 19, 2019

Additional problem. This project is using a Behat Mink Extension which seems to not had any updates in over two years, thereby no PHP 7.x updates (https://github.com/Behat/MinkExtension). A root problem could be an incompatibility. Do we know why Mink is being used rather than just using Behat? @LionsAd do you have any guidance or answer to the Behat Mink question?

@hugovk
Copy link
Contributor

hugovk commented Aug 14, 2019

PHP 5.4 is no longer supported for Drupal 7

Sorry, was looking at the wrong page (https://www.drupal.org/docs/8/system-requirements/php-requirements instead of https://www.drupal.org/docs/7/system-requirements/php-requirements)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants