Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to generator Java code from a HTTP testCase #369

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

Agility6
Copy link
Contributor

根据golang_generator实现java_generator

#366

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort. It is great.

I have tested all three Java source files. It works well. But the license part still needs your attention.

pkg/generator/java_generator.go Outdated Show resolved Hide resolved
pkg/generator/data/main.java.tpl Show resolved Hide resolved
@LinuxSuRen
Copy link
Owner

By the way, it's totally ok but it's not recommended to use your master branch to create a PR. See also my detailed explanation if you are interested in it.

This comment will not block the merge process. You can try it in your next PR.

@LinuxSuRen LinuxSuRen added the enhancement New feature or request label Apr 19, 2024
@LinuxSuRen
Copy link
Owner

LinuxSuRen commented Apr 19, 2024

The unit tests failed due to the following lines:

assert.Equal(t, 3, len(generators.Data))

The number should be 4 because you just added a new one.

Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Agility6
Copy link
Contributor Author

I noticed that I didn't test remote_server_test.go locally, I only ran code_generator_test.go. how should I run all the tests locally to make sure they all pass before submitting the PR?

@LinuxSuRen
Copy link
Owner

how should I run all the tests locally to make sure they all pass before submitting the PR?

You can run make test

Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy to have you as the 15th contributor. Hopefully this project could help you in some way.

@LinuxSuRen LinuxSuRen merged commit 9ce40e3 into LinuxSuRen:master Apr 19, 2024
10 checks passed
@Agility6
Copy link
Contributor Author

So happy to have you as the 15th contributor. Hopefully this project could help you in some way.

That's great! This project is awesome I will continue to research and contribute to the project🤩

@LinuxSuRen
Copy link
Owner

It's great!

image

@LinuxSuRen
Copy link
Owner

I noticed that I didn't test remote_server_test.go locally

hi @Agility6 , I'm wondering if you are interested in to create a PR template for that. Make a check list for all PRs. So the new contributors will know what they need to do.

@Agility6
Copy link
Contributor Author

I noticed that I didn't test remote_server_test.go locally

hi @Agility6 , I'm wondering if you are interested in to create a PR template for that. Make a check list for all PRs. So the new contributors will know what they need to do.

😁 My pleasure and I am very willing to try to do this. This is my first time doing this and I may need to learn how to complete this a PR template" first.

@LinuxSuRen LinuxSuRen added the ospp 开源之夏 https://summer-ospp.ac.cn/ label May 17, 2024
LinuxSuRen pushed a commit that referenced this pull request Jun 17, 2024
* chore(deps): update jenkins/jenkins docker tag to v2.421

* Update app version

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-action update-app-version <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ospp 开源之夏 https://summer-ospp.ac.cn/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants