feat: allow disabling padding #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Could you add it to the readme as well? |
|
You right @LinusU! I forgot to add the Done now |
LinusU
reviewed
Jun 25, 2018
readme.md
Outdated
| @@ -39,6 +44,8 @@ listed below. | |||
| - `'RFC4648-HEX'` - [base32hex from RFC4648](https://tools.ietf.org/html/rfc4648) | |||
| - `'Crockford'` - [Crockford's Base32](http://www.crockford.com/wrmg/base32.html) | |||
|
|
|||
| Options may have a `padding` property which provides a way to disable the encoding padding (default behaviour) | |||
There was a problem hiding this comment.
Since the default is different for different variants, could we say something like:
optionsmay have apaddingproperty which provides a way to forcefully enable or disable padding. The default behavior is to follow the default of the selectedvariant.
There was a problem hiding this comment.
done @LinusU !
|
Super, thank you so much! |
|
Published as v1.1.0 🚢 |
|
Thanks for the quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2