Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is splited from PR #164
This PR focuses on spliting out the fix for qsort function in glibc for wasm compatibility
In C, it is legal to cast a function pointer to another type (potentially with fewer parameters) and then invoke it with the “wrong” number of arguments. The qsort implementation in glibc relies on this trick. However, this behavior violates Wasm’s strict function signature rules and results in a runtime error under Wasm. More discussion here
While it’s possible to work around this with wasm-opt’s emulated function pointer casting, that approach introduces significant overhead across the entire Wasm binary. Instead, this PR directly modifies glibc’s source to remove the qsort function pointer trick, avoiding the need for binary rewriting.
The main change is duplicating the qsort implementation with a function signature that has one fewer parameter. This eliminates the function pointer casting and makes qsort work in a Wasm environment.