-
Notifications
You must be signed in to change notification settings - Fork 12
[Refactor] Network-related syscall typemap #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: threei-integration
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good except for the function name
} | ||
|
||
/// Converts a user-space socket address into a host-compatible `sockaddr` used for syscalls. | ||
pub fn sc_convert_host_sockaddr(arg: *mut u8, arg_cageid: u64, cageid: u64) -> (*mut sockaddr, u32) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the arg
should be u64
} | ||
|
||
/// Copies a socket address structure from the kernel into user space based on the given address family. | ||
pub fn sc_convert_copy_out_sockaddr( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's each argument mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to convert to Lind-defined sockaddr
instead of libc::SockAddr, right?
No description provided.