Skip to content

[Refactor] Add system-related calls (excluding exec) #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: syscall-read-open-close-mkdir
Choose a base branch
from
Draft

[Refactor] Add system-related calls (excluding exec) #157

wants to merge 3 commits into from
+567 −9

Conversation

celinehoang177
Copy link
Contributor

@Yaxuan-w Yaxuan-w mentioned this pull request Mar 31, 2025
Open
@Yaxuan-w Yaxuan-w changed the title Add system-related calls (excluding exec) [Refactor] Add system-related calls (excluding exec) Apr 16, 2025
rennergade
rennergade reviewed Jun 9, 2025
View reviewed changes
src/rawposix/src/sys_calls.rs

/// Those functions are required by wasmtime to create the first cage. `verbosity` indicates whether
/// detailed error messages will be printed if set
pub fn lindrustinit(verbosity: isize) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two function names are pretty bad (and they're my fault!) as relics from the really initial version of rustposix. maybe we change this to rawposix_initialize etc? makes it a bit better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they're also not really "sys system calls" is there a better file for them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rennergade rennergade rennergade left review comments

@JustinCappos JustinCappos Awaiting requested review from JustinCappos

@ChinmayShringi ChinmayShringi Awaiting requested review from ChinmayShringi

@Yaxuan-w Yaxuan-w Awaiting requested review from Yaxuan-w

@qianxichen233 qianxichen233 Awaiting requested review from qianxichen233

@robinyuan1002 robinyuan1002 Awaiting requested review from robinyuan1002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@celinehoang177 @rennergade @Yaxuan-w