feat: Isolate job output in cli #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport - Add JobOfferSubscription struct to support optional job ID filtering - Modify SubscribeToJobOfferUpdates to return an unsubscribe function - Introduce new SubscribeToJobOfferUpdatesWithFilter method - Update job offer update mechanism to respect job ID filters - Refactor JobCreator to use an interface for better extensibility
- Modify job offer update subscription to use filtered subscription - Add support for optional event subscriber - Enhance logging with job container ID - Print data ID immediately upon job result
…te-job-output-in-cli
…calling AddJobOffer, improving the reliability of job tracking.
hollygrimm
changed the title
bgins
approved these changes
Mar 5, 2025
|
@bgins yes, since there is only ever one subscription per job id, it makes sense that we remove the nextSubID counter. thanks for your review |
…te-job-output-in-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes the following changes:
By isolating job output, tools like the Discord Observer can run jobs in parallel and get the appropriate job output.
Task/Issue reference
Closes: 404
Test plan
Start the stack. Run the integration tests:
./stack integration-testsRun a job and compare the logs in the cli with the logs in this pull request.