Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Rename Preprocess to InputTransform #951

Merged
merged 22 commits into from
Nov 9, 2021
Merged

Conversation

ananyahjha93
Copy link
Contributor

@ananyahjha93 ananyahjha93 commented Nov 9, 2021

What does this PR do?

Fixes #918

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #951 (63b4d3a) into master (a244f42) will decrease coverage by 3.51%.
The diff coverage is 94.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
- Coverage   88.31%   84.79%   -3.52%     
==========================================
  Files         242      243       +1     
  Lines       12922    12939      +17     
==========================================
- Hits        11412    10972     -440     
- Misses       1510     1967     +457     
Flag Coverage Δ
unittests 84.79% <94.08%> (-3.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/classification/cli.py 100.00% <ø> (ø)
flash/audio/speech_recognition/cli.py 100.00% <ø> (ø)
flash/core/data/base_viz.py 100.00% <ø> (ø)
flash/core/data/data_source.py 94.80% <ø> (ø)
flash/graph/classification/cli.py 92.30% <ø> (ø)
flash/image/classification/cli.py 84.61% <ø> (ø)
flash/image/detection/cli.py 100.00% <ø> (ø)
flash/image/instance_segmentation/cli.py 100.00% <ø> (ø)
flash/image/keypoint_detection/cli.py 100.00% <ø> (ø)
flash/image/segmentation/cli.py 100.00% <ø> (ø)
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a244f42...63b4d3a. Read the comment docs.

@ethanwharris ethanwharris changed the title Rename preprocess to input Rename Preprocess to InputTransform Nov 9, 2021
@ethanwharris ethanwharris changed the title Rename Preprocess to InputTransform Rename Preprocess to InputTransform Nov 9, 2021
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

flash/__init__.py Outdated Show resolved Hide resolved
flash/core/data/batch.py Outdated Show resolved Hide resolved
flash/core/data/data_module.py Outdated Show resolved Hide resolved
@ethanwharris ethanwharris merged commit 8c9903d into master Nov 9, 2021
@ethanwharris ethanwharris deleted the refactor/rename_preprocess branch November 9, 2021 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Preprocess to InputTransform
2 participants