Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix broken notebooks #932

Merged
merged 3 commits into from
Nov 4, 2021
Merged

Fix broken notebooks #932

merged 3 commits into from
Nov 4, 2021

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #932 (0e1292b) into master (f2b08da) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #932   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files         238      238           
  Lines       12917    12917           
=======================================
  Hits        11497    11497           
  Misses       1420     1420           
Flag Coverage Δ
unittests 89.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/classification/model.py 92.59% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b08da...0e1292b. Read the comment docs.

@ethanwharris ethanwharris added bug / fix Something isn't working documentation Improvements or additions to documentation labels Nov 4, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smaller is better

@ethanwharris ethanwharris merged commit 642e63f into master Nov 4, 2021
@ethanwharris ethanwharris deleted the bugfix/broken_notebooks branch November 4, 2021 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants