Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Change torchmetrics version #902

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Change torchmetrics version #902

merged 3 commits into from
Oct 29, 2021

Conversation

twsl
Copy link
Contributor

@twsl twsl commented Oct 29, 2021

What does this PR do?

Fixes #901

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #902 (04f0896) into master (9927853) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #902   +/-   ##
=======================================
  Coverage   89.02%   89.02%           
=======================================
  Files         237      237           
  Lines       12884    12884           
=======================================
  Hits        11470    11470           
  Misses       1414     1414           
Flag Coverage Δ
unittests 89.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9927853...04f0896. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this! LGTM 😃

@twsl twsl marked this pull request as ready for review October 29, 2021 23:33
@ethanwharris ethanwharris merged commit 6c2e8ac into Lightning-Universe:master Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locked torchmetrics version
2 participants