Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add hints for tabular #90

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Add type hints for tabular

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #90 (9692215) into master (841986a) will decrease coverage by 8.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   86.63%   78.08%   -8.55%     
==========================================
  Files          45       45              
  Lines        1369     1369              
==========================================
- Hits         1186     1069     -117     
- Misses        183      300     +117     
Flag Coverage Δ
unittests 78.08% <100.00%> (-8.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/tabular/classification/data/data.py 84.70% <ø> (ø)
flash/tabular/classification/data/dataset.py 75.75% <100.00%> (ø)
flash/text/seq2seq/core/data.py 30.13% <0.00%> (-54.80%) ⬇️
flash/text/classification/data.py 31.86% <0.00%> (-53.85%) ⬇️
flash/text/classification/model.py 66.66% <0.00%> (-30.31%) ⬇️
flash/text/seq2seq/translation/model.py 55.55% <0.00%> (-16.67%) ⬇️
flash/text/seq2seq/summarization/metric.py 84.48% <0.00%> (-12.07%) ⬇️
flash/text/seq2seq/translation/data.py 76.92% <0.00%> (-7.70%) ⬇️
flash/text/seq2seq/summarization/data.py 76.92% <0.00%> (-7.70%) ⬇️
flash/text/seq2seq/core/model.py 61.90% <0.00%> (-6.35%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841986a...9692215. Read the comment docs.

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just fix the failing tests

@Borda Borda added the enhancement New feature or request label Feb 8, 2021
@kaushikb11 kaushikb11 merged commit 5aecfad into Lightning-Universe:master Feb 8, 2021
@kaushikb11 kaushikb11 deleted the tab/annotation branch February 8, 2021 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants