Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

ASR HUGGINGFACE_BACKBONES use AutoModel #874

Merged
merged 9 commits into from
Nov 24, 2021
Merged

ASR HUGGINGFACE_BACKBONES use AutoModel #874

merged 9 commits into from
Nov 24, 2021

Conversation

flozi00
Copy link
Contributor

@flozi00 flozi00 commented Oct 15, 2021

What does this PR do?

This PR replaces the huggingface wav2vec for ctc with their automodel for ctc

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #874 (29e08a2) into master (5f11d8f) will decrease coverage by 3.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
- Coverage   88.40%   85.00%   -3.40%     
==========================================
  Files         250      250              
  Lines       13199    13199              
==========================================
- Hits        11668    11220     -448     
- Misses       1531     1979     +448     
Flag Coverage Δ
unittests 85.00% <100.00%> (-3.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/speech_recognition/backbone.py 100.00% <100.00%> (ø)
flash/text/question_answering/model.py 28.27% <0.00%> (-62.76%) ⬇️
flash/text/question_answering/data.py 28.16% <0.00%> (-58.87%) ⬇️
flash/text/classification/cli.py 53.84% <0.00%> (-46.16%) ⬇️
flash/text/classification/data.py 55.44% <0.00%> (-41.46%) ⬇️
flash/text/question_answering/cli.py 60.00% <0.00%> (-40.00%) ⬇️
flash/text/seq2seq/core/data.py 66.06% <0.00%> (-24.25%) ⬇️
flash/text/question_answering/finetuning.py 3.92% <0.00%> (-19.61%) ⬇️
flash/text/classification/model.py 77.55% <0.00%> (-14.29%) ⬇️
flash/text/seq2seq/core/model.py 60.00% <0.00%> (-8.89%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f11d8f...29e08a2. Read the comment docs.

@SeanNaren
Copy link
Contributor

This is great :) ping us when this is ready @flozi00

@flozi00 flozi00 marked this pull request as ready for review October 20, 2021 10:41
@flozi00
Copy link
Contributor Author

flozi00 commented Oct 20, 2021

Failing tests are caused by other reasons, for example 404 error from HF hub
@SeanNaren

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@ethanwharris ethanwharris added enhancement New feature or request Ready to Go labels Nov 24, 2021
@ethanwharris ethanwharris merged commit 4cda031 into Lightning-Universe:master Nov 24, 2021
@flozi00 flozi00 deleted the patch-1 branch November 25, 2021 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Ready to Go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants