Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

HotFix for doc build on master #849

Merged
merged 1 commit into from
Oct 11, 2021
Merged

HotFix for doc build on master #849

merged 1 commit into from
Oct 11, 2021

Conversation

SeanNaren
Copy link
Contributor

What does this PR do?

Currently the docs are failing on master. This seems to be because of a numpy error. Mocking this seems to not work, thus for now installing the library within the docs may be a suitable hotfix.

@SeanNaren SeanNaren self-assigned this Oct 11, 2021
@SeanNaren SeanNaren added documentation Improvements or additions to documentation bug / fix Something isn't working labels Oct 11, 2021
@SeanNaren SeanNaren changed the title Add question answering thumbnail Fix doc build on master Oct 11, 2021
@SeanNaren SeanNaren changed the title Fix doc build on master HotFix for doc build on master Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #849 (a57dd98) into master (eb1fcd3) will decrease coverage by 11.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #849       +/-   ##
===========================================
- Coverage   89.00%   77.84%   -11.16%     
===========================================
  Files         224      224               
  Lines       12117    12117               
===========================================
- Hits        10785     9433     -1352     
- Misses       1332     2684     +1352     
Flag Coverage Δ
unittests 77.84% <ø> (-11.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/integrations/icevision/transforms.py 13.33% <0.00%> (-80.84%) ⬇️
...lash/image/embedding/vissl/transforms/multicrop.py 27.27% <0.00%> (-69.70%) ⬇️
...lash/image/embedding/vissl/transforms/utilities.py 14.63% <0.00%> (-68.30%) ⬇️
flash/image/detection/serialization.py 28.57% <0.00%> (-65.31%) ⬇️
flash/image/embedding/heads/vissl_heads.py 36.36% <0.00%> (-63.64%) ⬇️
flash/text/question_answering/model.py 28.76% <0.00%> (-62.33%) ⬇️
flash/core/integrations/icevision/backbones.py 33.33% <0.00%> (-60.01%) ⬇️
flash/text/question_answering/data.py 27.93% <0.00%> (-59.05%) ⬇️
...age/face_detection/backbones/fastface_backbones.py 42.10% <0.00%> (-57.90%) ⬇️
flash/image/embedding/vissl/adapter.py 31.76% <0.00%> (-56.48%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb1fcd3...a57dd98. Read the comment docs.

@Borda Borda merged commit f4313af into master Oct 11, 2021
@Borda Borda deleted the fix/docs branch October 11, 2021 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants