Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[Doc] #813

Merged
merged 2 commits into from
Sep 29, 2021
Merged

[Doc] #813

merged 2 commits into from
Sep 29, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Sep 29, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #813 (c37b2c0) into master (f495d9d) will increase coverage by 4.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
+ Coverage   84.88%   89.05%   +4.17%     
==========================================
  Files         219      219              
  Lines       11916    11916              
==========================================
+ Hits        10115    10612     +497     
+ Misses       1801     1304     -497     
Flag Coverage Δ
unittests 89.05% <ø> (+4.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/data_module.py 94.90% <0.00%> (+0.72%) ⬆️
flash/text/seq2seq/translation/model.py 77.27% <0.00%> (+4.54%) ⬆️
flash/text/seq2seq/summarization/model.py 80.95% <0.00%> (+4.76%) ⬆️
flash/core/integrations/labelstudio/data_source.py 86.81% <0.00%> (+5.49%) ⬆️
flash/text/seq2seq/core/model.py 77.10% <0.00%> (+9.63%) ⬆️
flash/text/question_answering/finetuning.py 19.78% <0.00%> (+14.28%) ⬆️
flash/text/classification/model.py 92.72% <0.00%> (+23.63%) ⬆️
flash/text/seq2seq/core/data.py 90.24% <0.00%> (+24.39%) ⬆️
flash/text/seq2seq/core/metrics.py 99.07% <0.00%> (+25.00%) ⬆️
flash/text/seq2seq/core/utils.py 100.00% <0.00%> (+30.00%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f495d9d...c37b2c0. Read the comment docs.

@tchaton tchaton enabled auto-merge (squash) September 29, 2021 10:17
@tchaton tchaton merged commit 892f759 into master Sep 29, 2021
@tchaton tchaton deleted the add_numpy branch September 29, 2021 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants