This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add from_lists to TextClassificationData
#805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
+ Coverage 88.97% 89.05% +0.08%
==========================================
Files 219 219
Lines 11879 11916 +37
==========================================
+ Hits 10569 10612 +43
+ Misses 1310 1304 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kingyiusuen
requested review from
ananyahjha93,
Borda,
carmocca,
ethanwharris,
justusschock,
kaushikb11 and
tchaton
as code owners
tchaton
reviewed
Sep 27, 2021
flash/text/classification/data.py
Outdated
| hf_dataset = Dataset.from_dict({"input": input, "labels": target}) | ||
|
|
||
| if not self.predicting: | ||
| dataset.multi_label = False |
There was a problem hiding this comment.
Would you mind adding support for multi label ?
kingyiusuen
changed the title
from_list to TextClassificationDatafrom_lists to TextClassificationData
SeanNaren
approved these changes
Sep 29, 2021
|
Thank you @kingyiusuen!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #769 (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃