Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

TextClassificationData from_dataframe #785

Merged
merged 6 commits into from
Sep 22, 2021
Merged

TextClassificationData from_dataframe #785

merged 6 commits into from
Sep 22, 2021

Conversation

kingyiusuen
Copy link
Contributor

What does this PR do?

Fixes #768

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #785 (2479d08) into master (40cb3ab) will increase coverage by 3.87%.
The diff coverage is 82.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   85.71%   89.58%   +3.87%     
==========================================
  Files         213      213              
  Lines       11309    11354      +45     
==========================================
+ Hits         9693    10172     +479     
+ Misses       1616     1182     -434     
Flag Coverage Δ
unittests 89.58% <82.97%> (+3.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/classification/data.py 89.23% <82.97%> (+26.31%) ⬆️
flash/core/model.py 87.58% <0.00%> (+0.21%) ⬆️
flash/text/seq2seq/translation/model.py 77.27% <0.00%> (+4.54%) ⬆️
flash/text/seq2seq/summarization/model.py 80.95% <0.00%> (+4.76%) ⬆️
flash/tabular/classification/model.py 93.33% <0.00%> (+8.88%) ⬆️
flash/text/seq2seq/core/model.py 77.10% <0.00%> (+9.63%) ⬆️
flash/text/question_answering/finetuning.py 19.78% <0.00%> (+14.28%) ⬆️
flash/text/classification/model.py 92.72% <0.00%> (+23.63%) ⬆️
flash/text/seq2seq/core/data.py 90.24% <0.00%> (+24.39%) ⬆️
flash/text/seq2seq/core/metrics.py 99.07% <0.00%> (+25.00%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40cb3ab...2479d08. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! LGTM 😃

@ethanwharris ethanwharris merged commit 0c8c24d into Lightning-Universe:master Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support from_dataframe for text classification
2 participants