Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

[Feat] Add ActiveLearning Loop Customization v2 #779

Merged
merged 40 commits into from
Sep 23, 2021
Merged

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Sep 20, 2021

What does this PR do?

This PR integrates Baal within Flash to offer ActiveLearning Training.

Fixes #761

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot removed the has conflicts label Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #779 (0aa0c97) into master (81b73ad) will decrease coverage by 2.14%.
The diff coverage is 42.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
- Coverage   87.16%   85.02%   -2.15%     
==========================================
  Files         213      217       +4     
  Lines       11405    11623     +218     
==========================================
- Hits         9941     9882      -59     
- Misses       1464     1741     +277     
Flag Coverage Δ
unittests 85.02% <42.66%> (-2.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/data_module.py 94.50% <ø> (ø)
...ash/image/classification/integrations/baal/loop.py 34.83% <34.83%> (ø)
...ash/image/classification/integrations/baal/data.py 40.86% <40.86%> (ø)
.../image/classification/integrations/baal/dropout.py 45.00% <45.00%> (ø)
flash/core/trainer.py 84.12% <92.30%> (+0.94%) ⬆️
flash/core/utilities/imports.py 90.76% <100.00%> (+0.07%) ⬆️
...image/classification/integrations/baal/__init__.py 100.00% <100.00%> (ø)
flash/text/question_answering/model.py 29.16% <0.00%> (-61.81%) ⬇️
flash/text/question_answering/data.py 28.29% <0.00%> (-58.53%) ⬇️
flash/text/classification/cli.py 53.84% <0.00%> (-46.16%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b73ad...0aa0c97. Read the comment docs.

@tchaton tchaton changed the title Active learning 2 [Feat] Add ActiveLearning Loop Customization Sep 21, 2021
@tchaton tchaton changed the title [Feat] Add ActiveLearning Loop Customization [Feat] Add ActiveLearning Loop Customization v2 Sep 21, 2021
@tchaton tchaton added this to the v0.6 milestone Sep 21, 2021
@tchaton tchaton self-assigned this Sep 21, 2021
@tchaton tchaton added the enhancement New feature or request label Sep 21, 2021
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could we have some documentation?

Copy link
Contributor

@pietrolesci pietrolesci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments regarding the test dataset in the ActiveLearningDataModule

Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crushing it @tchaton!

@mergify mergify bot removed the has conflicts label Sep 23, 2021
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pietrolesci pietrolesci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great work @tchaton!

@tchaton
Copy link
Contributor Author

tchaton commented Sep 23, 2021

LGTM

Great work @tchaton!

Thanks @pietrolesci for helping understand what was required :) Great team work !

Next step, let's reproduce the result from Baal, LabelStudio integration.

Best,
T.C

@tchaton tchaton enabled auto-merge (squash) September 23, 2021 10:52
@tchaton tchaton merged commit 649c689 into master Sep 23, 2021
@tchaton tchaton deleted the active_learning_2 branch September 23, 2021 11:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Feature: support Active Learning training loop
7 participants