Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

New README #756

Merged
merged 68 commits into from
Sep 14, 2021
Merged

New README #756

merged 68 commits into from
Sep 14, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Sep 12, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #756 (a12e217) into master (c06ebce) will increase coverage by 4.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   84.98%   89.07%   +4.09%     
==========================================
  Files         198      198              
  Lines       10681    10693      +12     
==========================================
+ Hits         9077     9525     +448     
+ Misses       1604     1168     -436     
Flag Coverage Δ
unittests 89.07% <100.00%> (+4.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/utilities/imports.py 91.17% <100.00%> (+0.06%) ⬆️
flash/image/classification/transforms.py 93.75% <100.00%> (+3.27%) ⬆️
flash/text/seq2seq/translation/model.py 77.27% <0.00%> (+4.54%) ⬆️
flash/text/seq2seq/summarization/model.py 80.95% <0.00%> (+4.76%) ⬆️
flash/text/seq2seq/core/model.py 77.10% <0.00%> (+9.63%) ⬆️
flash/text/question_answering/finetuning.py 19.78% <0.00%> (+14.28%) ⬆️
flash/text/classification/model.py 93.10% <0.00%> (+22.41%) ⬆️
flash/text/seq2seq/core/data.py 90.24% <0.00%> (+24.39%) ⬆️
flash/text/seq2seq/core/metrics.py 99.07% <0.00%> (+25.00%) ⬆️
flash/text/classification/data.py 91.01% <0.00%> (+28.08%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c06ebce...a12e217. Read the comment docs.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tchaton tchaton marked this pull request as ready for review September 14, 2021 15:38
@Borda Borda added the documentation Improvements or additions to documentation label Sep 14, 2021
@tchaton tchaton merged commit d963de7 into master Sep 14, 2021
@tchaton tchaton deleted the docs/new_readme branch September 14, 2021 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants