Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix drop last for predicting and testing #671

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #671 (65791b8) into master (9b86a0f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #671   +/-   ##
=======================================
  Coverage   90.01%   90.01%           
=======================================
  Files         185      185           
  Lines        9664     9664           
=======================================
  Hits         8699     8699           
  Misses        965      965           
Flag Coverage Δ
unittests 90.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/model.py 86.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b86a0f...65791b8. Read the comment docs.

@ethanwharris ethanwharris merged commit 4e89a37 into master Aug 17, 2021
@ethanwharris ethanwharris deleted the bugfix/fix_predict_drop_last branch August 17, 2021 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant