Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Audio data sources + Numpy file support #651

Merged
merged 23 commits into from
Aug 13, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Aug 12, 2021

What does this PR do?

Fixes #649
Fixes #650

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #651 (cd3a806) into master (ddd942d) will decrease coverage by 0.04%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
- Coverage   90.63%   90.59%   -0.05%     
==========================================
  Files         173      173              
  Lines        9179     9235      +56     
==========================================
+ Hits         8319     8366      +47     
- Misses        860      869       +9     
Flag Coverage Δ
gpu ?
pytest ?
unittests 90.59% <91.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/model.py 86.41% <ø> (ø)
flash/image/classification/model.py 76.92% <ø> (ø)
flash/video/classification/data.py 81.81% <50.00%> (-0.59%) ⬇️
flash/image/data.py 95.94% <78.57%> (-4.06%) ⬇️
flash/core/data/data_source.py 94.61% <91.56%> (-1.21%) ⬇️
flash/audio/classification/data.py 93.02% <95.65%> (-0.73%) ⬇️
flash/audio/classification/transforms.py 100.00% <100.00%> (ø)
flash/core/data/data_module.py 94.57% <100.00%> (+0.04%) ⬆️
flash/core/data/transforms.py 100.00% <100.00%> (ø)
flash/core/utilities/imports.py 89.71% <100.00%> (-0.10%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd942d...cd3a806. Read the comment docs.

@Borda Borda marked this pull request as draft August 13, 2021 19:41
@Borda Borda changed the title [WIP] Audio data sources + Numpy file support Audio data sources + Numpy file support Aug 13, 2021
@ethanwharris ethanwharris marked this pull request as ready for review August 13, 2021 21:23
@ethanwharris ethanwharris merged commit 6596669 into master Aug 13, 2021
@ethanwharris ethanwharris deleted the feature/audio_data_sources branch August 13, 2021 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AudioClassificationData.from_csv AudioClassificationData from_folders / from_files in .npy format
1 participant