-
Notifications
You must be signed in to change notification settings - Fork 212
QuestionAnsweringTask and QuestionAnsweringData with SQuADDatSource. #607
QuestionAnsweringTask and QuestionAnsweringData with SQuADDatSource. #607
Conversation
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
==========================================
- Coverage 90.01% 89.36% -0.66%
==========================================
Files 195 197 +2
Lines 9975 10502 +527
==========================================
+ Hits 8979 9385 +406
- Misses 996 1117 +121
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @karthikrangasai just a few small comments
- Reason: - Providing a QA model from huggingface as the backbone fails to load - huggingface doesn't seem to treat QnA task a Seq2Seq task. - Work - Made the implementations of the QuestionAnswering data and task independent from Seq2Seq.
…estionAnswering from HF and process SQUAD dataset in the proper format
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really awesome work!!!! Just a few small comments, maybe just remove the deserializer / serve stuff for now and we can add it in a follow-up PR with an example?
Sure, I will remove the serve and deserializer code. |
What does this PR do?
Fixes #577
Fixes #540
Fixes #541
QuestionAnsweringTask
andQuestionAnsweringData
to handle HF AutoModelForQuestionAnswering as backbone.SQuADDataSource
.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃