Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Face Detection Task (task-a-thon) #606

Merged

Conversation

borhanMorphy
Copy link
Contributor

@borhanMorphy borhanMorphy commented Jul 20, 2021

What does this PR do?

Fixes # (#503 #504 #505 #506 #507 #508)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jul 20, 2021

Hello @borhanMorphy! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-20 09:39:33 UTC

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #606 (a94b107) into master (892f759) will decrease coverage by 0.05%.
The diff coverage is 85.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   89.05%   89.00%   -0.06%     
==========================================
  Files         219      224       +5     
  Lines       11916    12111     +195     
==========================================
+ Hits        10612    10779     +167     
- Misses       1304     1332      +28     
Flag Coverage Δ
unittests 89.00% <85.64%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/face_detection/model.py 82.35% <82.35%> (ø)
flash/image/face_detection/data.py 84.28% <84.28%> (ø)
flash/core/data/utils.py 95.57% <84.61%> (-1.43%) ⬇️
flash/core/utilities/imports.py 90.83% <100.00%> (+0.07%) ⬆️
flash/image/__init__.py 100.00% <100.00%> (ø)
flash/image/face_detection/__init__.py 100.00% <100.00%> (ø)
flash/image/face_detection/backbones/__init__.py 100.00% <100.00%> (ø)
...age/face_detection/backbones/fastface_backbones.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 892f759...a94b107. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borhanMorphy Awesome work so far, looks really cool!!! I've left a few comments, mostly around moving preprocessing / postprocessing out of the model and also enabling from_datasets rather than using from_data_source directly.

flash/image/face_detection/data.py Show resolved Hide resolved
flash/image/face_detection/data.py Outdated Show resolved Hide resolved
flash/image/face_detection/data.py Outdated Show resolved Hide resolved
flash/image/face_detection/model.py Outdated Show resolved Hide resolved
flash/image/face_detection/model.py Outdated Show resolved Hide resolved
flash/image/face_detection/model.py Outdated Show resolved Hide resolved
flash_examples/face_detection.py Outdated Show resolved Hide resolved
@mergify mergify bot added the has conflicts label Aug 5, 2021
@ananyahjha93 ananyahjha93 enabled auto-merge (squash) September 24, 2021 16:58
@mergify mergify bot removed the has conflicts label Sep 29, 2021
@Borda Borda added enhancement New feature or request Task-a-thon labels Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Task-a-thon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants