Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add Speech Recognition Task (Wav2Vec) #586

Merged
merged 48 commits into from
Jul 19, 2021
Merged

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jul 14, 2021

What does this PR do?

Adds a speech recognition task based on the HF port of Wav2Vec.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added enhancement New feature or request task flash Task Task-a-thon labels Jul 14, 2021
@SeanNaren SeanNaren self-assigned this Jul 14, 2021
@pep8speaks
Copy link

pep8speaks commented Jul 14, 2021

Hello @SeanNaren! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-19 17:52:10 UTC

@SeanNaren SeanNaren changed the title New Speech Recognition Task (Wav2Vec) Add Speech Recognition Task (Wav2Vec) Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #586 (bfe8ea6) into master (ea4604f) will decrease coverage by 0.06%.
The diff coverage is 85.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
- Coverage   90.04%   89.98%   -0.07%     
==========================================
  Files         144      149       +5     
  Lines        8251     8457     +206     
==========================================
+ Hits         7430     7610     +180     
- Misses        821      847      +26     
Flag Coverage Δ
gpu ?
pytest ?
unittests 89.98% <85.64%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/speech_recognition/data.py 74.13% <74.13%> (ø)
flash/audio/speech_recognition/model.py 97.14% <97.14%> (ø)
flash/audio/__init__.py 100.00% <100.00%> (ø)
flash/audio/speech_recognition/__init__.py 100.00% <100.00%> (ø)
flash/audio/speech_recognition/backbone.py 100.00% <100.00%> (ø)
flash/audio/speech_recognition/collate.py 100.00% <100.00%> (ø)
flash/core/data/batch.py 96.51% <100.00%> (+0.06%) ⬆️
flash/core/data/process.py 86.86% <100.00%> (+0.28%) ⬆️
flash/core/utilities/imports.py 91.50% <100.00%> (+0.33%) ⬆️
flash/core/serve/flash_components.py 90.74% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea4604f...bfe8ea6. Read the comment docs.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress !

flash/audio/speech_recognition/data.py Outdated Show resolved Hide resolved
flash/audio/speech_recognition/data.py Outdated Show resolved Hide resolved
flash/audio/speech_recognition/data.py Outdated Show resolved Hide resolved
flash/audio/speech_recognition/data.py Outdated Show resolved Hide resolved
flash/audio/speech_recognition/data.py Outdated Show resolved Hide resolved
flash/audio/speech_recognition/data.py Outdated Show resolved Hide resolved
flash/audio/speech_recognition/data.py Outdated Show resolved Hide resolved
flash/audio/speech_recognition/data.py Outdated Show resolved Hide resolved
flash/audio/speech_recognition/data.py Outdated Show resolved Hide resolved
flash/audio/speech_recognition/model.py Outdated Show resolved Hide resolved
@SeanNaren SeanNaren enabled auto-merge (squash) July 19, 2021 11:17
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 😃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

# set os environ variable for multiprocesses
os.environ["PYTHONWARNINGS"] = "ignore"

model = self.backbones.get(backbone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird formatting.

@SeanNaren SeanNaren merged commit b8b4ebc into master Jul 19, 2021
@SeanNaren SeanNaren deleted the feat/speech_recognition branch July 19, 2021 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request task flash Task Task-a-thon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants