Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Fix GPU CI #557

Merged
merged 13 commits into from
Jul 10, 2021
Merged

Fix GPU CI #557

merged 13 commits into from
Jul 10, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jul 9, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #557 (654c4ea) into master (ddd85f0) will increase coverage by 1.51%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   89.80%   91.32%   +1.51%     
==========================================
  Files         112      112              
  Lines        7193     7196       +3     
==========================================
+ Hits         6460     6572     +112     
+ Misses        733      624     -109     
Flag Coverage Δ
unittests 91.32% <22.22%> (+1.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/classification/model.py 86.66% <0.00%> (ø)
flash/tabular/classification/model.py 93.18% <0.00%> (ø)
flash/text/classification/model.py 93.18% <0.00%> (+22.72%) ⬆️
flash/video/classification/model.py 86.41% <0.00%> (ø)
flash/core/data/data_module.py 93.53% <66.66%> (+0.08%) ⬆️
flash/text/seq2seq/translation/model.py 76.19% <0.00%> (+4.76%) ⬆️
flash/text/seq2seq/summarization/model.py 80.00% <0.00%> (+5.00%) ⬆️
flash/text/seq2seq/core/model.py 73.91% <0.00%> (+7.24%) ⬆️
flash/text/seq2seq/core/data.py 92.00% <0.00%> (+20.00%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd85f0...654c4ea. Read the comment docs.

@ethanwharris ethanwharris marked this pull request as ready for review July 10, 2021 10:40
@ethanwharris ethanwharris merged commit fb5e577 into master Jul 10, 2021
@ethanwharris ethanwharris deleted the ci/fix_gpu branch July 10, 2021 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants