Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Update API to work with latest transformers/datasets package #40

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

SeanNaren
Copy link
Contributor

What does this PR do?

We shouldn't rely on such an older version for transformers/datasets. This will require re-training the model (which I've done locally, Once approved I can upload the new model weights to S3).

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #40 (3a7036f) into master (176efbd) will decrease coverage by 0.01%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   87.07%   87.06%   -0.02%     
==========================================
  Files          28       28              
  Lines         859      866       +7     
==========================================
+ Hits          748      754       +6     
- Misses        111      112       +1     
Flag Coverage Δ
unittests 87.06% <90.90%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/classification/data.py 85.71% <83.33%> (-0.34%) ⬇️
flash/core/classification.py 93.75% <100.00%> (+0.41%) ⬆️
flash/text/classification/model.py 96.96% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176efbd...46c972f. Read the comment docs.

Copy link
Contributor

@teddykoker teddykoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

@SeanNaren SeanNaren enabled auto-merge (squash) February 1, 2021 17:17

import torch
from transformers.modeling_outputs import SequenceClassifierOutput
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import

@SeanNaren SeanNaren disabled auto-merge February 1, 2021 17:56
@SeanNaren SeanNaren enabled auto-merge (squash) February 1, 2021 17:59
@SeanNaren SeanNaren merged commit bd3d50d into master Feb 1, 2021
@SeanNaren SeanNaren deleted the feaure/update_classification branch February 1, 2021 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants