Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add more backbones to semantic segmentation #370

Merged
merged 6 commits into from
Jun 7, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jun 7, 2021

What does this PR do?

Fixes #369

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

flash/image/segmentation/backbones.py Outdated Show resolved Hide resolved
flash/image/segmentation/backbones.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #370 (e62fc9b) into master (447c28e) will decrease coverage by 9.17%.
The diff coverage is 68.18%.

❗ Current head e62fc9b differs from pull request most recent head ee56cd7. Consider uploading reports for the commit ee56cd7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   88.82%   79.65%   -9.18%     
==========================================
  Files          80       80              
  Lines        4144     4173      +29     
==========================================
- Hits         3681     3324     -357     
- Misses        463      849     +386     
Flag Coverage Δ
gpu ?
pytest ?
unittests 79.65% <68.18%> (-9.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/segmentation/model.py 42.62% <0.00%> (-47.21%) ⬇️
flash/image/backbones.py 67.96% <64.28%> (-18.45%) ⬇️
flash/image/segmentation/backbones.py 79.06% <75.00%> (-20.94%) ⬇️
flash/image/detection/data.py 40.32% <0.00%> (-56.46%) ⬇️
flash/image/segmentation/data.py 36.87% <0.00%> (-51.88%) ⬇️
flash/image/classification/data.py 47.67% <0.00%> (-48.84%) ⬇️
flash/image/detection/model.py 33.33% <0.00%> (-46.67%) ⬇️
flash/image/segmentation/transforms.py 60.00% <0.00%> (-40.00%) ⬇️
flash/image/detection/finetuning.py 62.50% <0.00%> (-37.50%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 447c28e...ee56cd7. Read the comment docs.

@ethanwharris ethanwharris enabled auto-merge (squash) June 7, 2021 11:13
@ethanwharris ethanwharris merged commit e31081c into master Jun 7, 2021
@ethanwharris ethanwharris deleted the feature/segmentation_backbones branch June 7, 2021 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More backbones for semantic segmentation
3 participants