Cluster

[tchaton]

What does this PR do?

Fixes # (issue)

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes?
• Did you write any new necessary tests? [not needed for typos/docs]
• Did you verify new and existing tests pass locally with your changes?
• If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

• Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[pep8speaks]

Hello @tchaton! Thanks for updating this PR.

• In the file flash/vision/embedding/image_embedder_model.py:

Line 31:1: E731 do not assign a lambda expression, use a def
Line 32:1: E731 do not assign a lambda expression, use a def

Comment last updated at 2021-02-01 19:30:01 UTC

[codecov]

Codecov Report

Merging #36 (c9a2869) into master (48ec088) will decrease coverage by 4.24%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   85.43%   81.19%   -4.25%     
==========================================
  Files          29       32       +3     
  Lines         927     1037     +110     
==========================================
+ Hits          792      842      +50     
- Misses        135      195      +60     

Flag	Coverage Δ
unittests	81.19% <45.45%> (-4.25%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
flash/vision/embedding/image_embedder_model.py	35.61% <35.61%> (ø)
flash/vision/embedding/model_map.py	43.47% <43.47%> (ø)
flash/core/model.py	95.40% <100.00%> (+0.73%)	⬆️
flash/vision/__init__.py	100.00% <100.00%> (ø)
flash/vision/embedding/__init__.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ec088...356d02d. Read the comment docs.

[carmocca]

Can we have some tests? Also add the example to test_examples if it's not too slow

[carmocca]

fix indentation