Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[RFC] Add nbstripout to pre-commit hooks #336

Merged
merged 5 commits into from
May 26, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented May 25, 2021

What does this PR do?

Adds nbstripout to pre-commit hooks to remove outputs in notebooks.
https://github.com/kynan/nbstripout

Before submitting

  • [RFC] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the tests / CI Tests and continuous integration label May 25, 2021
@akihironitta akihironitta marked this pull request as ready for review May 25, 2021 06:30
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #336 (088904b) into master (660438f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          80       80           
  Lines        4061     4061           
=======================================
  Hits         3598     3598           
  Misses        463      463           
Flag Coverage Δ
unittests 88.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 660438f...088904b. Read the comment docs.

@justusschock justusschock enabled auto-merge (squash) May 26, 2021 06:42
@justusschock justusschock merged commit 2796f37 into master May 26, 2021
@justusschock justusschock deleted the ci/precommit-nbstripout branch May 26, 2021 07:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests / CI Tests and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants