-
Notifications
You must be signed in to change notification settings - Fork 210
Conversation
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
=======================================
Coverage 88.59% 88.59%
=======================================
Files 80 80
Lines 4061 4061
=======================================
Hits 3598 3598
Misses 463 463
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
367979b
to
4b8a4cd
Compare
The failing test should be addressed in #334.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had this at one point before and the GPU tests continued to run on every branch but it also caused the coverage tracking to break as it thought every GPU coverage report was on the master branch. Don't know what was causing that, but this still seems to be running GPU tests on this branch, so I'm not sure it's doing what we want...
@akihironitta @Borda - It looks like we should be able to set trigger: None, pr: None to stop it from running on non-master branches: https://stackoverflow.com/a/66048645
@akihironitta @Borda @ethanwharris we have a similar setup in kornia that could help: https://github.com/kornia/kornia/blob/master/.github/workflows/tests_cpu_versions.yml#L3-L9 |
@ethanwharris Thank you for your investigation! I just turned them off with the following lines.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM 😃
yes but you use GHA and this is Azure pipelines so the syntax and behaviour is a bit different... |
@ethanwharris just thinking we shall keep triggers for tags so can use the badge in pypi... what do you think? |
@Borda Yeah, that seems reasonable, we should probably run all tests on releases 😃 |
What does this PR do?
cc @Borda
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃