Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Run tests on GPUs nightly only #333

Merged
merged 8 commits into from
May 26, 2021
Merged

Run tests on GPUs nightly only #333

merged 8 commits into from
May 26, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented May 22, 2021

What does this PR do?

cc @Borda

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests? [not needed for typos/docs]
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the tests / CI Tests and continuous integration label May 22, 2021
@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #333 (1480783) into master (2796f37) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          80       80           
  Lines        4061     4061           
=======================================
  Hits         3598     3598           
  Misses        463      463           
Flag Coverage Δ
unittests 88.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2796f37...1480783. Read the comment docs.

@akihironitta akihironitta marked this pull request as ready for review May 23, 2021 23:05
@akihironitta
Copy link
Contributor Author

The failing test should be addressed in #334.

FAILED tests/examples/test_scripts.py::test_example[predict-translation.py]

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had this at one point before and the GPU tests continued to run on every branch but it also caused the coverage tracking to break as it thought every GPU coverage report was on the master branch. Don't know what was causing that, but this still seems to be running GPU tests on this branch, so I'm not sure it's doing what we want...

@akihironitta @Borda - It looks like we should be able to set trigger: None, pr: None to stop it from running on non-master branches: https://stackoverflow.com/a/66048645

@edgarriba
Copy link
Contributor

@akihironitta @Borda @ethanwharris we have a similar setup in kornia that could help: https://github.com/kornia/kornia/blob/master/.github/workflows/tests_cpu_versions.yml#L3-L9

@akihironitta
Copy link
Contributor Author

@ethanwharris Thank you for your investigation! I just turned them off with the following lines.

trigger: none
pr: none

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 😃

@ethanwharris ethanwharris enabled auto-merge (squash) May 26, 2021 07:15
@akihironitta akihironitta changed the title Run tests on GPUs nightly Run tests on GPUs nightly only May 26, 2021
@ethanwharris ethanwharris merged commit 2113c11 into master May 26, 2021
@ethanwharris ethanwharris deleted the ci/gpu-nightly branch May 26, 2021 07:28
@Borda
Copy link
Member

Borda commented May 26, 2021

@akihironitta @Borda @ethanwharris we have a similar setup in kornia that could help: https://github.com/kornia/kornia/blob/master/.github/workflows/tests_cpu_versions.yml#L3-L9

yes but you use GHA and this is Azure pipelines so the syntax and behaviour is a bit different...

@Borda
Copy link
Member

Borda commented May 26, 2021

@ethanwharris just thinking we shall keep triggers for tags so can use the badge in pypi... what do you think?
cc: @akihironitta

@ethanwharris
Copy link
Collaborator

@Borda Yeah, that seems reasonable, we should probably run all tests on releases 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests / CI Tests and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants