Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Minor doc fixes #301

Merged
merged 16 commits into from
May 19, 2021
Merged

Minor doc fixes #301

merged 16 commits into from
May 19, 2021

Conversation

akihironitta
Copy link
Contributor

What does this PR do?

Includes minor fixes and improvements in the docs which I find while reading.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the documentation Improvements or additions to documentation label May 14, 2021
@akihironitta akihironitta self-assigned this May 14, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #301 (4729518) into master (f12f55c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files          78       78           
  Lines        4021     4021           
=======================================
  Hits         3495     3495           
  Misses        526      526           
Flag Coverage Δ
unittests 86.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/data_pipeline.py 92.43% <ø> (ø)
flash/core/data/process.py 94.20% <ø> (ø)
flash/core/model.py 87.04% <ø> (ø)
flash/core/trainer.py 79.36% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12f55c...4729518. Read the comment docs.

@tchaton tchaton marked this pull request as ready for review May 19, 2021 17:51
@tchaton tchaton merged commit 65c658b into master May 19, 2021
@tchaton tchaton deleted the docs/fix-colab-link branch May 19, 2021 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants