Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Notebook fix #3

Closed
wants to merge 1 commit into from
Closed

Notebook fix #3

wants to merge 1 commit into from

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jan 28, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #3 (bb558b2) into master (7b9102d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files          27       27           
  Lines         857      857           
=======================================
  Hits          746      746           
  Misses        111      111           
Flag Coverage Δ
unittests 87.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9102d...bb558b2. Read the comment docs.

@Borda Borda changed the title Notebook fix 2 Notebook fix Jan 28, 2021
@Borda
Copy link
Member

Borda commented Jan 28, 2021

@tchaton history fixed

@Borda Borda force-pushed the notebook_fix_2 branch 2 times, most recently from 9721d16 to bc76fff Compare January 28, 2021 21:54
@Borda Borda added the bug / fix Something isn't working label Jan 28, 2021
@Borda
Copy link
Member

Borda commented Jan 28, 2021

@tchaton seems that the notebooks are still failing....

@Borda Borda force-pushed the notebook_fix_2 branch 2 times, most recently from ead99d1 to bb558b2 Compare January 28, 2021 23:47
@Borda Borda mentioned this pull request Jan 29, 2021
16 tasks
@tchaton tchaton closed this Jan 29, 2021
@Borda Borda deleted the notebook_fix_2 branch January 29, 2021 20:58
tchaton pushed a commit that referenced this pull request Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants