Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Docs cleanup and migrate to testcode #293

Merged
merged 33 commits into from
May 13, 2021
Merged

Docs cleanup and migrate to testcode #293

merged 33 commits into from
May 13, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented May 12, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #293 (3b0c883) into master (7d8d159) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   88.44%   88.44%           
=======================================
  Files          74       74           
  Lines        3626     3626           
=======================================
  Hits         3207     3207           
  Misses        419      419           
Flag Coverage Δ
unittests 88.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8d159...3b0c883. Read the comment docs.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ethanwharris ethanwharris changed the title Migrate to testcode Docs cleanup and migrate to testcode May 13, 2021
@ethanwharris ethanwharris marked this pull request as ready for review May 13, 2021 17:43
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda added the documentation Improvements or additions to documentation label May 13, 2021
docs/source/common/finetuning_example.rst Show resolved Hide resolved
docs/source/reference/text_classification.rst Show resolved Hide resolved
docs/source/general/finetuning.rst Show resolved Hide resolved
docs/source/reference/object_detection.rst Outdated Show resolved Hide resolved
@ethanwharris ethanwharris enabled auto-merge (squash) May 13, 2021 18:52
@ethanwharris ethanwharris merged commit 1f50b3f into master May 13, 2021
@ethanwharris ethanwharris deleted the docs/testcode branch May 13, 2021 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants