Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[feat] add support for metadata + resize Semantic Segmentation Image #290

Merged
merged 21 commits into from
May 12, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented May 12, 2021

What does this PR do?

This PR adds support for metadata and resize the predicted label images.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this May 12, 2021
@tchaton tchaton added this to the 0.3 milestone May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #290 (8349d40) into master (41b9850) will increase coverage by 0.09%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   88.39%   88.49%   +0.09%     
==========================================
  Files          74       74              
  Lines        3612     3642      +30     
==========================================
+ Hits         3193     3223      +30     
  Misses        419      419              
Flag Coverage Δ
unittests 88.49% <95.12%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/vision/segmentation/data.py 88.75% <81.81%> (+<0.01%) ⬆️
flash/core/model.py 89.75% <100.00%> (ø)
flash/data/batch.py 82.35% <100.00%> (+1.73%) ⬆️
flash/data/data_source.py 96.87% <100.00%> (+0.02%) ⬆️
flash/vision/segmentation/model.py 92.72% <100.00%> (+2.02%) ⬆️
flash/vision/segmentation/serialization.py 82.60% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b9850...8349d40. Read the comment docs.

@tchaton tchaton marked this pull request as ready for review May 12, 2021 18:02
@tchaton tchaton changed the title [feat] add support for metadata [feat] add support for metadata + resize Semantic Segmentation Image May 12, 2021
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃 small typo

flash/data/batch.py Outdated Show resolved Hide resolved
@tchaton tchaton merged commit 74fbafd into master May 12, 2021
@tchaton tchaton deleted the update_segmentation_resizing branch May 12, 2021 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants